Skip to content

Update AudioAnalyzer.yaml #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2024
Merged

Update AudioAnalyzer.yaml #911

merged 3 commits into from
Nov 11, 2024

Conversation

@rbxphogen
Copy link
Contributor

@rbxphogen rbxphogen commented Nov 11, 2024 •
edited
Loading

Changes

Add a note about AudioAnalyzer:GetSpectrum returning an empty array.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@rbxphogen
Update AudioAnalyzer.yaml
1218468 
Add a note about AudioAnalyzer:GetSpectrum returning an empty array.
@github-actions github-actions bot added the engine reference Changes the Engine API Reference documentation label Nov 11, 2024
rbxphogen
rbxphogen commented Nov 11, 2024
View reviewed changes
@rbxphogen rbxphogen marked this pull request as ready for review November 11, 2024 18:52
@rbxphogen rbxphogen requested a review from a team as a code owner November 11, 2024 18:52
@github-actions github-actions bot added the changes requested This pull request has changes requested prior to merging label Nov 11, 2024
matthewzhang-rbx
matthewzhang-rbx approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@matthewzhang-rbx matthewzhang-rbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way, seems fine

@rbxphogen rbxphogen merged commit 8af0167 into main Nov 11, 2024
3 checks passed
@rbxphogen rbxphogen deleted the audioanalyzer-empty-array branch November 11, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewzhang-rbx matthewzhang-rbx matthewzhang-rbx approved these changes

@aetter aetter aetter approved these changes

@fumminger fumminger fumminger approved these changes

Assignees

No one assigned

Labels

changes requested This pull request has changes requested prior to merging engine reference Changes the Engine API Reference documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rbxphogen @aetter @fumminger @matthewzhang-rbx